镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(reactions): render laugh reaction as 😄 to match GitHub - #689

Open
danmin20 wants to merge 1 commit into
utterance:masterfrom
danmin20:fix/laugh-reaction-emoji
Open

danmin20 wants to merge 1 commit into
utterance:masterfrom
danmin20:fix/laugh-reaction-emoji

Conversation

@danmin20

Copy link
Copy Markdown

Problem

The laugh reaction is rendered with a different emoji in utterances than on GitHub itself, so the same reaction looks like two different reactions depending on where you view it.

Emoji Code point
GitHub issue thread 😄 U+1F604 (:smile:)
utterances widget 😂 U+1F602

The underlying reaction is the same laugh value in the Reactions API; only the glyph chosen by the client differs.

Change

  • src/reactions.ts: change the laugh entry in reactionEmoji from 😂 to 😄, matching GitHub's rendering.
  • Remove the stray leading U+FE0F variation selector that was in front of that entry.

No other reaction entries are touched.

What:
- Change the `laugh` entry in `reactionEmoji` from 😂 (U+1F602) to 😄 (U+1F604)
- Drop the stray leading U+FE0F variation selector on that entry

Why:
- GitHub renders the `laugh` reaction as 😄 (:smile:), so the same reaction
  showed as a different face in utterances vs. the GitHub issue thread

AI-Use: yes
AI-Model: claude-fable-5-1
AI-Contribution: 90%
@IGhost-P

Copy link
Copy Markdown

+1 — I ran into exactly this and independently arrived at the same one-line fix before finding this PR, so I'd really like to see it merged.

To confirm the problem from my side: the laugh reaction is the same laugh value in the Reactions API everywhere, but GitHub renders it as 😄 (U+1F604) while utterances renders it as 😂 (U+1F602). Readers who compare the widget with the linked issue see what looks like two different reactions, and people have asked me why the "laugh" count on the blog doesn't match the emoji on GitHub. The current mapping has been unchanged since reactions were added in #116, so it's simply a glyph choice that drifted from GitHub's, not a font or platform rendering issue.

I checked out this branch and verified the byte sequence on the changed line is f0 9f 98 84 (U+1F604) with the stray U+FE0F removed. It's a single-line change to src/reactions.ts, touches no other reactions, and has no behavioural impact beyond the glyph.

This is a small but very visible consistency fix for anyone embedding utterances. Would appreciate a merge and a redeploy of the hosted client whenever you get a chance. Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants