Repository navigation
Conversation
What: - Change the `laugh` entry in `reactionEmoji` from 😂 (U+1F602) to 😄 (U+1F604) - Drop the stray leading U+FE0F variation selector on that entry Why: - GitHub renders the `laugh` reaction as 😄 (:smile:), so the same reaction showed as a different face in utterances vs. the GitHub issue thread AI-Use: yes AI-Model: claude-fable-5-1 AI-Contribution: 90%
|
+1 — I ran into exactly this and independently arrived at the same one-line fix before finding this PR, so I'd really like to see it merged. To confirm the problem from my side: the I checked out this branch and verified the byte sequence on the changed line is This is a small but very visible consistency fix for anyone embedding utterances. Would appreciate a merge and a redeploy of the hosted client whenever you get a chance. Thank you! |
Problem
The
laughreaction is rendered with a different emoji in utterances than on GitHub itself, so the same reaction looks like two different reactions depending on where you view it.:smile:)The underlying reaction is the same
laughvalue in the Reactions API; only the glyph chosen by the client differs.Change
src/reactions.ts: change thelaughentry inreactionEmojifrom 😂 to 😄, matching GitHub's rendering.No other reaction entries are touched.