Repository navigation
Feature/ruff fix - #17
Open
alexvalentine94 wants to merge 4 commits into
Open
alexvalentine94 wants to merge 4 commits into
alexvalentine94 wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff fixes and formatting
Merge with "Create a merge commit" (not squash or rebase) so the formatting commit hash listed in
.git-blame-ignore-revsstays valid.Commits
ruff check --fix: 891 safe fixes across 64 files (unused imports, import sorting, modern type annotations, f-strings without placeholders, redundantpass, etc.)decomposemultiprocessnow importsDecompositionSolidfromdecomposesolid, where it is defined, rather than fromdecomposeruff format: 75 files reformatted, layout only. Every file parses to the same code as before..git-blame-ignore-revs: lists the format commit sogit blameand GitHub's blame view skip it. Locally:git config blame.ignoreRevsFile .git-blame-ignore-revsResults
mciomodules import; examples and CLI run; MCNP decks from the examples are identical apart from timestampscasadi,OCP, optionalopenmc/cadquery) kept, and no module relied on a removed nameRemaining findings (need manual review)
316 findings that aren't auto-fixable, including mutable default arguments (B006), loop-variable closures (B023), bare/blanket
except(E722, BLE001) and unused variables (F841).Reviewing
Review commit 1 for code changes; commit 2 is formatting only (
git diff -wshows nothing beyond quotes and line wrapping).