You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Superconductor critical current density parameterisations are not all kludged #4630
In odd parts of the space (e.g. T < 1.5 K, B -> B_crit) many of these functions can return negative results, and possibly imaginary results, and also possibly NaNs.
I think all these functions should return real, positive numbers (ideally tending towards, but never reaching 0.0 for really odd parts of the space). This is purely for optimisation purposes, below e.g. 1 A/m^2 the current density is effectively 0.0 but some gradients may be required to stop the optimiser getting stuck.
Proposed solution
Check which of these produces negative, or imaginary or NaNs for bad inputs and kludge appropriately.
I don't believe that treating negative input temperatures should be required after #4628 is implemented, but they are probably an issue at present.
changed the title [-]SUperconductor critical current density parameterisations are not all kludged[/-][+]Superconductor critical current density parameterisations are not all kludged[/+]on Oct 1, 2026
Hi @grmtrkngtn - I believe you offered to implement this. Many thanks.
For what it's worth, I would suggest that it is preferable if the functions produce positive real values even for negative temperatures (and are monotonic in temperature).
Activity
[-]SUperconductor critical current density parameterisations are not all kludged[/-][+]Superconductor critical current density parameterisations are not all kludged[/+]mkovari commentedon Oct 1, 2026
Hi @grmtrkngtn - I believe you offered to implement this. Many thanks.
For what it's worth, I would suggest that it is preferable if the functions produce positive real values even for negative temperatures (and are monotonic in temperature).