镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Superconductor critical current density parameterisations are not all kludged #4630

Open

Description

@CoronelBuendia

Description of issue / requirement to address

Several critical current density surface parameterisations are available in PROCESS, see https://github.com/ukaea/PROCESS/blob/main/process/models/superconductors.py

In odd parts of the space (e.g. T < 1.5 K, B -> B_crit) many of these functions can return negative results, and possibly imaginary results, and also possibly NaNs.

I think all these functions should return real, positive numbers (ideally tending towards, but never reaching 0.0 for really odd parts of the space). This is purely for optimisation purposes, below e.g. 1 A/m^2 the current density is effectively 0.0 but some gradients may be required to stop the optimiser getting stuck.

Proposed solution

Check which of these produces negative, or imaginary or NaNs for bad inputs and kludge appropriately.

I don't believe that treating negative input temperatures should be required after #4628 is implemented, but they are probably an issue at present.

Activity

  1. changed the title [-]SUperconductor critical current density parameterisations are not all kludged[/-] [+]Superconductor critical current density parameterisations are not all kludged[/+] on Oct 1, 2026
  2. mkovari commented on Oct 1, 2026

    @mkovari
    Collaborator

    Hi @grmtrkngtn - I believe you offered to implement this. Many thanks.

    For what it's worth, I would suggest that it is preferable if the functions produce positive real values even for negative temperatures (and are monotonic in temperature).

  3. self-assigned this
    on Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions