镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: align supported Node engine range - #222

Merged
marshallku merged 2 commits into
toss:mainfrom
poketopa:fix/node-engine-range
Oct 8, 2026
Merged

marshallku merged 2 commits into
toss:mainfrom
poketopa:fix/node-engine-range

Conversation

@poketopa

Copy link
Copy Markdown
Contributor

Summary

  • require Node.js 20 or later in package.json, matching the oldest runtime covered by binding CI
  • update the English and Korean installation guides to state the same support floor

Rationale

PR #209 removed Node.js 18 from the test matrix and the v0.7.0 release notes record that support change. The binding matrix now verifies Node.js 20, 24, and 26 across macOS, Windows, and Linux, while the package metadata and installation guides still advertised Node.js 10-era support.

Validation

  • yarn install --immutable
  • just format
  • just lint
  • just typecheck
  • just test
  • git diff --check

@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

@poketopa is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@poketopa
poketopa marked this pull request as ready for review August 23, 2026 13:30
@poketopa
poketopa requested a review from seokju-na as a code owner August 23, 2026 13:30

@marshallku marshallku left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The previous range was not accurate anyway: index.js already calls require('node:fs'), which needs Node 14.18/16+, and CI only tests Node 20/24/26. So >=20 now matches what is actually supported and tested.

Checked locally: merges cleanly into main, and the three touched files stay consistent with each other.

Severity: P1 must fix before merge · P2 should fix before merge · P3 worth fixing · P4 suggestion.

Comment thread package.json
},
"engines": {
"node": ">= 10.20.0 < 11 || >= 12.17.0 < 13 || >= 14.0.0"
"node": ">=20"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4 · release — This narrows the declared support range, so users on Node 18 will start getting an EBADENGINE warning (or an install failure with engine-strict). fix: is fine since the old range was never really supported, but it would be worth a line in the release notes, e.g. "Node.js 20 or later is now the declared minimum, matching what CI tests."

@marshallku
marshallku merged commit bea71d2 into toss:main Oct 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants