镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Hyphen based ligatures don't work in WPF #259

Open

Description

@citizenmatt

This is related to the issues people have reported with Visual Studio where ligatures that contain a hyphen, such as -> or <!-- don't work in Visual Studio.

It actually looks like this might be a generic WPF issue, rather than just Visual Studio.

I created a dummy WPF application that simply included a TextBlock, Label and FlowDocumentReader. The TextBlock and Label will display ligatures correctly, apart from those containing hyphens (e.g. ->). Strangely, the FlowDocumentReader works as expected.

screen shot 2016-08-29 at 10 51 33 am

I tried to debug the Visual Studio editor, and as best as I could follow, it's not the editor that's doing the work to display ligatures - it comes automagically from WPF and Windows. It looks like the editor is using Windows' native "Line Services" and for some reason, this component is treating the hyphen as a separate character, rather than as part of a run - and so it gets rendered separately, and not converted into a ligature. Hyphenation appears to be disabled in the Visual Studio editor code, and it's definitely disabled in the TextBlock and Label in my dummy application.

I've no idea now what's going wrong, and I strongly suspect this is a WPF/Windows issue and not something that could be fixed in the font, but I'm hoping that we get a nice friendly WPF expert wandering past who can help out.

Could it be something stupid like Windows doesn't recognise "hyphen" in the ligatures?

Anyone got any ideas?

Activity

  1. clairernovotny commented on Aug 30, 2016

    @clairernovotny

    This isn't Windows, it's WPF. If you try in a UWP app, it renders correctly. I asked folks at VS to look into it and here's what they found so far:

    Looks line LineServices (a low-level component that WPF uses to help format text) treats ‘-‘ specially, presumably for the line-breaking algorithm. With the result that it’s never placed in the same glyph run as normal characters like ‘>’. So by the time DWrite sees the text, it looks like GlyphRun(“--") GlyphRun(“> >= ==> 3/4"), and DWrite doesn’t recognize the ligature that changes ‘-->’ into the right-arrow glyph.

  2. citizenmatt commented on Aug 30, 2016

    @citizenmatt
    Author

    Nice one - very useful info! Is there any indication of a fix being worked on?

  3. saul commented on Nov 6, 2016

    @saul

    @onovotny have you received any word from the guys at VS that this is being worked on?

  4. slang25 commented on Dec 19, 2016

    @slang25

    @onovotny are you able to use your influence to bring this up with them another time. I think there's about a month before VS2017 changes are frozen, it would be sweet if they can get this sorted in time, sounds like they are onto the root cause.

  5. Porges commented on Jan 6, 2017

    @Porges
  6. anjelo commented on Apr 18, 2017

    @anjelo
  7. saul commented on Apr 18, 2017

    @saul

    That's a real shame :(

  8. jogibear9988 commented on May 4, 2017

    @jogibear9988
  9. sgrottel commented on Jan 18, 2019

    @sgrottel

    Btw, it's also the same with VS 2019 preview.

  10. slang25 commented on Jan 19, 2019

    @slang25

    I've just got the notification that the issue is a "wont fix" :(

  11. clairernovotny commented on Jan 19, 2019

    @clairernovotny

    @slang25 I would wait until WPF for .NET Core 3 is fully open sourced.

  12. slang25 commented on Jan 19, 2019

    @slang25

    That's a very good point!

  13. limbusdev commented on Apr 10, 2019

    @limbusdev

    Persists in Visual Studio 2019.1

  14. lifeforce-dev commented on Feb 18, 2020

    @lifeforce-dev

    Bummer :( maybe one day it will come out of Won't Fix.

  15. HolisticDeveloper commented on Jun 12, 2020

    @HolisticDeveloper

    I overlooked this when scanning the history of this issue so I thought I would post an explicit comment. The issue is now tracked in the WPF team's GitHub issues: dotnet/wpf#109

  16. Vresod commented on Dec 12, 2024

    @Vresod

    dotnet/wpf#109 (comment) Looks like it's been resolved in .NET 9; visual studio still uses an older version but perhaps the issue will be resolved in VS2025?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions