Repository navigation
docs: show TUnit Native AOT in the homepage JIT race - #7724
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ReviewThe change is small and does what the description says. The AOT lane is added to the JIT view, the headline "N× faster" figure is still computed from JIT lanes only, and the dead Minor suggestions:
None of these block merging. |
[Low impact] The changes affect the homepage benchmark display and its implementation notes. The PR appears safe to merge, with a non-blocking improvement to the AOT comparison label. Findings
SummaryAdds a
Reviews (1) · Last reviewed commit: "docs: show TUnit Native AOT in the homep..." · Reviewed by Greptile |
| {formatMs(lane.ms)} | ||
| {index > 0 && <small>{(lane.ms / tunit.ms).toFixed(1)}× TUnit</small>} | ||
| {index > 0 && index < lanes.length && <small>{(lane.ms / tunit.ms).toFixed(1)}× TUnit</small>} | ||
| {index >= lanes.length && <small>{(tunit.ms / lane.ms).toFixed(1)}× faster than JIT</small>} |
There was a problem hiding this comment.
The new AOT label always says “faster than JIT,” even when lane.ms exceeds tunit.ms. If a future benchmark update reports slower AOT results, visitors would see something like “0.8× faster than JIT.” Handle slower and equal results explicitly, as the headline already does, or use a neutral ratio label.
The homepage race defaults to the JIT view, so the AOT numbers were only visible after clicking the Native AOT toggle, and nothing compared AOT against JIT.
TUnit (AOT)lane at the bottom of the JIT view, labelled with how much faster it is than TUnit on JIT (e.g. 3.6× for async, ~24× for data-driven in the latest run).BenchmarkHighlightcomponent, which nothing imported and which had a hardcoded "10x faster with Native AOT" claim, and updatesBENCHMARKS_IMPLEMENTATION.mdto match.Checked with
tscand a fulldocusaurus build; the rendered homepage has the new lane.