Repository navigation
Conversation
The "Working stories" link on the project overview pointed at /stories?status=working. The Stories page only reads the `phase` search parameter (parseStoriesSearch ignores `status`), and `working` is not a backlog phase, so the link silently opened the default open view instead of the stories that are in progress. Link to ?phase=in_progress and assert in the overview test that the link round-trips through parseStoriesSearch to that phase.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the project overview's "Running now" panel, "Working stories →" links to
/stories?status=working(apps/web/app/(app)/projects/[projectId]/page.tsx). The Stories page only readsphase(parseStoriesSearchinapps/web/lib/backlog-presentation.tshas nostatuskey), andworkingis not a backlog phase. Clicking the link opens the default "open" view instead of the stories in progress. Every other overview link already uses?phase=....Fix
Link to
?phase=in_progress.Tests
apps/web/test/overview-page.test.tsx: finds the "Working stories →" link in the Running now section, parses its query withparseStoriesSearchand expectsphaseto equal["in_progress"](fails on the old URL).Commands run
biome check(2.5.2) on the changed files: clean. Vitest not run locally; relying on CI.