You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Feature Request] Add codec HTTP server to the encryptedpayloads sample #491
Would be helpful if it verified token against jwks url and had commented out code for checking the email address against an approved list
👍 I don't remember why Java made this a top-level supported project when no other SDKs did, but that may need to be a customization made there and just leveraged here. In general though, it sounds like if this is something we want from our codec server samples, we should do it in all. (feel free to take over codec samples to make them more cohesive if they are not enough already, or just open other issues to have SDK do it, though unsure of prioritization)
I don't think it's cloud specific. Users setup JWKS on open source (https://github.com/temporalio/samples-go/tree/main/serverjwtauth) and extracting email from the JWT, if that's what you mean, may be a general thing depending on what it's extracting out of the claim. This can just be an option on the existing codec server in each sample IMO.
Activity
lorensr commentedon Aug 4, 2023
Looks like we have one here: https://github.com/temporalio/sdk-java/tree/master/temporal-remote-data-encoder
cretz commentedon Aug 4, 2023
Nice. May just need to use it in the sample then.
lorensr commentedon Aug 4, 2023
Would be helpful if it verified token against jwks url and had commented out code for checking the email address against an approved list
cretz commentedon Aug 4, 2023
👍 I don't remember why Java made this a top-level supported project when no other SDKs did, but that may need to be a customization made there and just leveraged here. In general though, it sounds like if this is something we want from our codec server samples, we should do it in all. (feel free to take over codec samples to make them more cohesive if they are not enough already, or just open other issues to have SDK do it, though unsure of prioritization)
lorensr commentedon Aug 5, 2023
I guess JWKS and email is cloud-specific, so maybe two different examples of the HTTP server routes.
cretz commentedon Aug 7, 2023
I don't think it's cloud specific. Users setup JWKS on open source (https://github.com/temporalio/samples-go/tree/main/serverjwtauth) and extracting email from the JWT, if that's what you mean, may be a general thing depending on what it's extracting out of the claim. This can just be an option on the existing codec server in each sample IMO.
IMO we should do it to all (or none).