Repository navigation
💥 Surface priority and fairness details in CLI output - #1217
moody-temporal wants to merge 4 commits into
Conversation
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73e55168ad
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
d8f9624 to
7d64d65
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5782014d6d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Related issues
What changed?
task-queue describe --report-priority-statsto show per-priority task counts for all build IDs, includingstatsByPriorityin JSON output when requested.Release notes 💥
The new
statsByPriorityfield changestask-queue describe -o jsonoutput when--report-priority-statsis used.Validation
go test ./... -count=1andcd cliext && go test ./... -count=1passed.Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
Help text
--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)Manual tests
Setup
temporal server start-dev \ --headless \ --dynamic-config-value matching.enableFairness=true temporal task-queue config set \ --task-queue YourTaskQueue \ --task-queue-type workflow \ --fairness-key-weight tenant-a=4.5 temporal workflow start \ --type YourWorkflowType \ --task-queue YourTaskQueue \ --workflow-id YourWorkflowId \ --priority-key 2 \ --fairness-key tenant-a \ --fairness-weight 5.5Happy path
$ temporal workflow describe \ --workflow-id YourWorkflowId # Priority: 2; fairness key: tenant-a; fairness weight: 5.5 $ temporal task-queue config get \ --task-queue YourTaskQueue \ --task-queue-type workflow # tenant-a has fairness weight 4.5 $ temporal task-queue describe \ --task-queue YourTaskQueue \ --report-priority-stats # Per-priority task counts include priority 2 $ temporal task-queue describe \ --task-queue YourTaskQueue \ --report-priority-stats \ --output json # statsByPriority contains the per-priority countsError case
$ temporal task-queue describe \ --task-queue YourTaskQueue \ --report-priority-stats \ --disable-stats Error: --report-priority-stats cannot be used with --disable-stats $ echo $? 1Composition
$ temporal activity start \ --activity-id YourActivityId \ --type YourActivityType \ --task-queue YourTaskQueue \ --start-to-close-timeout 5m \ --priority-key 2 \ --fairness-key tenant-a \ --fairness-weight 5.5 \ --output json | jq -r .runId YourRunId $ temporal activity describe \ --activity-id YourActivityId \ --run-id YourRunId # Priority: 2; fairness key: tenant-a; fairness weight: 5.5 $ temporal task-queue describe \ --task-queue YourTaskQueue \ --report-priority-stats # Activity queue stats include priority 2