Repository navigation
Use the new LTS Android NDK alone for both testing packages and for workflow pulls here - #315
Conversation
|
LTS NDK 30 is now the only supported one, but keep the older ones around until we ship a Swift 6.4 SDK built with NDK 30 and the GitHub CI have installed it in their runners. @marcprux and @justice-adams-apple, please review. |
|
@shahmishal, easy review |
| type: string | ||
| description: "The NDK versions to use when building with the Swift SDK for Android" | ||
| default: "[\"r27d\", \"r28c\"]" | ||
| default: "[\"r27d\", \"r28c\", \"r30\"]" |
There was a problem hiding this comment.
Yeah, I have no problem dropping anything before 30, as these are only the defaults and devs can always specify what they want.
If you prefer some other default, just let me know.
There was a problem hiding this comment.
Let's drop 27 and 28 from default
There was a problem hiding this comment.
Done, I only kept the old ones around for the default because we still supported 6.3, built with NDK 27, when I submitted this pull adding NDK 30 last week. Now that 6.4 is out, built with NDK 30, and all prior NDKs are unsupported, this is the right default.
…orkflow pulls here
|
@justice-adams-apple, this has been ready for a couple weeks, please merge. |
| android_sdk_triples: | ||
| type: string | ||
| description: "The triples to use when building with the Swift SDK for Android. The final triple in the list will be used for the emulator testing and should match the host architecture." | ||
| default: "[\"aarch64-unknown-linux-android28\", \"x86_64-unknown-linux-android28\"]" |
There was a problem hiding this comment.
@swiftlang/android-workgroup, wdyt about lowering this to API 23 or 24 by default, too old?
|
@shahmishal, can we get this in before the next tag in this workflows repo? This is ready. |
|
@shahmishal, would be good to get this in and tag the workflow, as we haven't had a tag since the 6.4 release. |
No description provided.