v1.4.7 doesn't working with react native 0.77 on Android #41

Activity

1. ianrumac commented on Feb 3, 2025

   

   ianrumac

   on Feb 3, 2025

   Contributor

   More actions

   Hey @jingp-ofload !
   This seems quite weird - could you share more details about the Android side of your setup?
   Testing our expo-example with both of these dependencies and it seems to be running smoothly - would be great if you could share your build.gradle file. Also, are you using RN with the new architecture enabled?
2. jp928 commented on Feb 3, 2025

   

   jp928

   on Feb 3, 2025

   More actions

   I do enabled new architecture which is by default. I guess the thing is react native 0.77 is shipped with Kotlin 2.0.2.
3. leomiller12 commented on Apr 3, 2025

   

   leomiller12

   on Apr 3, 2025

   More actions

   Someone found a solution?
4. jp928 commented on Apr 3, 2025

   

   jp928

   on Apr 3, 2025

   Last edited by jp928

   More actions

   @leomiller12 I am using "@superwall/react-native-superwall": "^2.0.9",
   and this is my patch

   diff --git a/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/SuperwallReactNativeModule.kt b/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/SuperwallReactNativeModule.kt
   index a38b4d5..54f6e9c 100644
   --- a/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/SuperwallReactNativeModule.kt
   +++ b/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/SuperwallReactNativeModule.kt
   @@ -156,10 +156,10 @@ class SuperwallReactNativeModule(private val reactContext: ReactApplicationConte
              .emit("paywallPresentationHandler", data)
          }
        }
   -
   +    val mapParams = params?.let { convertReadableMapToMap(it).filterValues { it != null } } as Map<String, Any>
        Superwall.instance.register(
          placement = event,
   -      params = params?.toHashMap(),
   +      params = mapParams,
          handler = handler,
          feature = {
            feature?.resolve(null)
   @@ -337,8 +337,9 @@ class SuperwallReactNativeModule(private val reactContext: ReactApplicationConte
        params: ReadableMap?,
        promise: Promise
      ) {
   +    val mapParams = params?.let { convertReadableMapToMap(it).filterValues { it != null } } as Map<String, Any>
        CoroutineScope(Dispatchers.IO).launch {
   -      Superwall.instance.getPresentationResult(event, params?.toHashMap()).fold({
   +      Superwall.instance.getPresentationResult(event, mapParams).fold({
            launch(Dispatchers.Main) {
              promise.resolve(it.toJson())
            }
   diff --git a/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/models/SuperwallOptions.kt b/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/models/SuperwallOptions.kt
   index e9e97fc..8b12772 100644
   --- a/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/models/SuperwallOptions.kt
   +++ b/node_modules/@superwall/react-native-superwall/android/src/main/java/com/superwallreactnative/models/SuperwallOptions.kt
   @@ -33,7 +33,7 @@ class SuperwallOptions {
            for (i in 0 until scopesArray.size()) {
              val scopeStr = scopesArray.getString(i)
              try {
   -            scopes.add(enumValueOf<LogScope>(scopeStr))
   +            scopes.add(scopeStr?.let { enumValueOf<LogScope>(it) })
              } catch (e: IllegalArgumentException) {}
            }
          }
   

   ❤️React with ❤️1Reacted by Leo
5. leomiller12 commented on Apr 4, 2025

   

   leomiller12

   on Apr 4, 2025

   More actions

   @jp928 thanks, I appreciate it!