You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fly config validate reports an invalid [[vm]] memory value as valid #5262
fly config validate accepts a config whose machine conversion fails, such as an unparsable memory value in a [[vm]] section. The command prints "Configuration is valid", and the error appears only later, when fly deploy converts the config to a machine config.
Steps to reproduce
Create a fly.toml with:
app = "foo"
[[vm]]
memory = "not-a-size"
Run fly config validate.
Expected
Validation fails and reports that converting to a machine in process group app will fail, with the parse error.
Actual
✓ Configuration is valid
The cause is in validateMachineConversion in internal/appconfig/validation.go. It checks the named return value err, which is always nil at that point, instead of the error returned by ToMachineConfig.
Activity