fix: resolve #1019 - #2789
Open
SrvFernandes wants to merge 1 commit into
Open
fix: resolve #1019#2789SrvFernandes wants to merge 1 commit into
SrvFernandes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #1019 by expanding the simulation output to include ALL cost metrics (not just CPU and memory) and ensuring budget information is returned even when simulation fails.
Changes Made:
Expanded
SimCoststruct to include all Soroban cost metrics:cpu_instructions(existing)mem_bytes(renamed frommemfor clarity)read_bytes(new)write_bytes(new)historical_data_bytes(new)footprint_bytes(new)Modified
SimulateOutputto include an optionalerrorfield, allowing cost data to be returned alongside error information.Updated
run()method inSimulateCmdto:Added
extract_cost_from_simulation_error()helper function to parse cost data from error responses.Added
Displayimplementations forSimCostandSimulateOutputto provide clear formatted output of all metrics.Benefits:
Closes #1019
/attempt
/claim #1019
Bounty Reward Wallet: 0x96eE7904BdCd8a82c71B4FFc3362C96b1Aae03e0 (Base / EVM)
Fixes #1019
OnlyDust Contribution
Reward Wallet: 0x96eE7904BdCd8a82c71B4FFc3362C96b1Aae03e0 (Base / EVM)