镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

chore: fix C lint errors (issue #15996) - #16031

Open
satyamsrivastava43-sketch wants to merge 1 commit into
stdlib-js:developfrom
satyamsrivastava43-sketch:fix-c-lint-15996
Open

satyamsrivastava43-sketch wants to merge 1 commit into
stdlib-js:developfrom
satyamsrivastava43-sketch:fix-c-lint-15996

Conversation

@satyamsrivastava43-sketch

@satyamsrivastava43-sketch satyamsrivastava43-sketch commented Oct 10, 2026 •

Copy link
Copy Markdown

Resolves #15996.

Description

Makes read-only input pointers in i32_to_f64, f64_to_i32, and generate const-correct to resolve the reported C lint errors.

Related Issues

resolves #15996

Questions

No.

Other

git diff --check passes. The project C lint workflow was not run locally.

Checklist

AI Assistance

  • Yes
  • Code generation
  • Research and understanding

Disclosure: OpenAI Codex analyzed the issue and drafted these const-qualifier changes.

@stdlib-js/reviewers

@satyamsrivastava43-sketch
satyamsrivastava43-sketch requested a review from a team October 10, 2026 06:27
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Oct 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

2 participants