You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support overriding Trino's liveness probe with other probe type #813
but i get this error in message in my trino worker statefulset:
create Pod trino-coac-worker-default-0 in StatefulSet trino-coac-worker-default failed error: Pod "trino-coac-worker-default-0" is invalid: spec.containers[0].livenessProbe.tcpSocket: Forbidden: may not specify more than 1 handler type
looks like it doesn't really override the livenessProbe as the tcpSocket field still exists?
Hi! Yes, you are pointing out a problem with our merging functionality.
We are using https://docs.rs/k8s-openapi/latest/k8s_openapi/trait.DeepMerge.html internally. Basically you can only add or override fields on structs, but not delete them.
If you have any ideas how we can ergonomically improve that (to allow deleting fields), that would be great!
PS: I actually ran into the exact same issue with probes in the past as well...
Activity
sbernauer commentedon Oct 31, 2025
Hi! Yes, you are pointing out a problem with our merging functionality.
We are using https://docs.rs/k8s-openapi/latest/k8s_openapi/trait.DeepMerge.html internally. Basically you can only add or override fields on structs, but not delete them.
If you have any ideas how we can ergonomically improve that (to allow deleting fields), that would be great!
PS: I actually ran into the exact same issue with probes in the past as well...
[-]overriding trino's livenessprobe[/-][+]Support overriding Trino's liveness probe with other probe type[/+]