镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

feat: add crd::openlineage module - #1250

Merged
razvan merged 22 commits into
mainfrom
feat/openlineage-crd
Oct 6, 2026
Merged

razvan merged 22 commits into
mainfrom
feat/openlineage-crd

Conversation

@razvan

@razvan razvan commented Jul 17, 2026 •

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#856

Decision: https://github.com/stackabletech/decisions/issues/90

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide. => I assume this will be done later
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@razvan razvan self-assigned this Jul 17, 2026
razvan and others added 15 commits July 17, 2026 09:47
…sSecretName

AuthenticationClass is a server-side identity abstraction and does not fit
outbound OpenLineage client->backend authentication, which is a static bearer
token. Replace `authentication_class_ref` on OpenLineageConnectionSpec with an
optional `credentials_secret_name` (a Secret holding the api key under `apiKey`)
and drop `resolve_authentication_class`.

See stackabletech/decisions#90

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… move CRD to lineage.stackable.tech

Rename the embeddable OpenLineageJob field `app_name` to `job_name` (serialized
`appName` -> `jobName`) and move the OpenLineageConnection CRD from the
`openlineage.stackable.tech` API group to `lineage.stackable.tech`.

Regenerated crds/OpenLineageConnection.yaml.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@razvan
razvan marked this pull request as ready for review October 5, 2026 10:27
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Oct 5, 2026

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to the CRD preview!

Comment thread crates/stackable-operator/src/crd/openlineage/mod.rs Outdated
Comment thread crates/stackable-operator/src/crd/openlineage/v1alpha1_impl.rs
Comment thread crates/stackable-operator/src/crd/openlineage/v1alpha1_impl.rs
@razvan
razvan requested a review from sbernauer October 5, 2026 13:09
Comment thread crates/stackable-operator/src/crd/openlineage/mod.rs Outdated
Comment thread crates/stackable-operator/src/crd/openlineage/v1alpha1_impl.rs Outdated
Comment thread crates/stackable-operator/src/crd/openlineage/v1alpha1_impl.rs
Comment thread crates/stackable-operator/src/crd/openlineage/v1alpha1_impl.rs
@razvan
razvan requested a review from sbernauer October 5, 2026 13:58

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRD and code LGTM, thanks a lot!
Checked that the CRD conforms the linked decision

Comment thread crates/stackable-operator/src/crd/openlineage/mod.rs
Comment thread crates/stackable-operator/src/crd/openlineage/v1alpha1_impl.rs
@razvan
razvan added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 1b564c0 Oct 6, 2026
5 checks passed
@razvan
razvan deleted the feat/openlineage-crd branch October 6, 2026 09:18
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Oct 19, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants