Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AttributedLabel only adjusted the line break mode when one paragraph style covered the whole string. With more than one paragraph style (for example, list items with their own indents), the display normalization was skipped, and the text storage used for link hit-testing and link frames kept truncating modes, which lay out each paragraph on a single line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
comp615
marked this pull request as ready for review
November 10, 2026 21:42
johnnewman-square
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttributedLabeladjusts the line break mode in two places:normalizingForView(with:), for display;makeTextStorage(), for the layout behind link hit-testing and link frames.Both read
AttributedText.paragraphStyle, which isnilunless a single paragraph style covers the whole string. Text with several paragraph styles skipped both adjustments, for example a list where each item has its own indent:.byTruncatingTail, which don't work withNSTextContainer. Links after a wrapped paragraph got the wrong tap targets and accessibility frames..byTruncatingHead/.byTruncatingMiddleon multi-line labels, and for wrapping modes on single-line labels.Both places now update a copy of every paragraph style range. A string with one paragraph style behaves as before.
🤖 Generated with Claude Code