Repository navigation
fix: reuse large-content viewer interaction on reattachment - #627
Open
robmaceachern wants to merge 1 commit into
Open
robmaceachern wants to merge 1 commit into
robmaceachern wants to merge 1 commit into
Conversation
Keep the container's existing interaction when it returns to a window, avoiding duplicate interactions after detachment or movement. Add a rendered-container regression for detach, same-window reattachment, and movement to a second window. --- *This response was drafted with AI assistance.*
robmaceachern
marked this pull request as ready for review
October 6, 2026 20:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Agent details
Contribution: Implementation and PR description
Agent: Codex
Session: Local Codex session
Reattaching a large-content viewer container currently installs another interaction, including when it returns to the same window. Reuse the existing interaction so detach, reattach, and movement to another window keep one interaction with the same identity.
The new regression fails on unchanged
main(two interactions after reattachment and three after movement) and passes with this fix. All eightAccessibilityContainerTestspass through Tuist on iPhone SE (3rd generation), iOS 17.5 / Xcode 26.5; pinned SwiftFormat passes for all 249 tracked Swift files.This response was drafted with AI assistance.