Repository navigation
Avoid closing response twice in toBodilessEntity - #37565
Open
guanchengang wants to merge 1 commit into
Open
guanchengang wants to merge 1 commit into
guanchengang wants to merge 1 commit into
Conversation
`toBodilessEntity()` wrapped the exchange function in try-with-resources, which closed the response inside the function. `exchangeInternal()` then closed the same response again in its finally block, since the default exchange call passes close=true. Remove the try-with-resources from `toBodilessEntity()` and let `exchangeInternal()` own the response lifecycle. Add a regression test asserting that the response is closed exactly once. Signed-off-by: Chengang Guan <guanchengang@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toBodilessEntity()wrapped the exchange function in try-with-resources, which closed the response inside the function.exchangeInternal()then closed the same response again in its finally block, since the default exchange call passesclose=true.Remove the try-with-resources from
toBodilessEntity()and letexchangeInternal()own the response lifecycle.Add a regression test asserting that the response is closed exactly once.