Repository navigation
Conversation
…getElementText ListBasedXMLEventReader#getElementText() threw an XMLStreamException when a comment or processing instruction appeared within the text content of an element. As specified by XMLStreamReader#getElementText() and as already implemented in AbstractXMLStreamReader#getElementText() and ListBasedXMLEventReader#nextTag(), such events are now skipped. Signed-off-by: lejuho <zedd1324@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListBasedXMLEventReader#getElementText()currently throws anXMLStreamException("Unexpected non-text event") when a comment or processing instruction appears within the text content of an element, e.g.<bar>ba<!-- comment -->z</bar>. The JDK'sXMLEventReaderreturns"baz"for the same input.The contract of
XMLStreamReader#getElementText()(whichXMLEventReader#getElementText()refers to) skipsCOMMENTandPROCESSING_INSTRUCTIONevents, and Spring's ownAbstractXMLStreamReader#getElementText()andListBasedXMLEventReader#nextTag()already skip them. This change alignsListBasedXMLEventReader#getElementText()with that behavior; other non-text events (e.g. a nestedSTART_ELEMENT) still result in an exception.Tests added for comments, processing instructions, comment-only content, and a nested element still throwing.