feat(cli): introduce `events` commands by bespoyasov · Pull Request #97 · spotify/confidence-cli

bespoyasov · 2026-10-05T07:43:25Z

Adds event management commands to the CLI: confidence events list|get|create|update|delete|usage
Adds generic MCP client in packages/core/src/mcp/ using @modelcontextprotocol/sdk, reusable for future command groups
Adds generic REST API client in packages/core/src/api/ (unused by events, ready for future commands)
Events commands call the confidence-flags MCP server tools (listEventDefinitions, getEventDefinition, createEventDefinition, updateEventDefinition, deleteEventDefinition, queryEventsUsage)
delete prompts for confirmation via @inquirer/confirm
Splits MSW test handlers into per-domain files under packages/testing/src/msw/handlers/
Exports extractRegion from core's auth barrel

Noticed that REST for events isn't supported yet, so had to introduce the MCP client in core, but I decided to keep the REST client in this PR as well (as it will be needed for other features anyways).

Commands

# List all event definitions
confidence events list

# Get details for a specific event
confidence events get page-viewed

# Create an event definition with typed fields
confidence events create --name purchase-completed \
  --field amount:double \
  --field currency:string \
  --field item_count:int

# Create from a JSON schema file
confidence events create --name signup --from-file schema.json

# Add fields to an existing event definition
confidence events update page-viewed --field referrer:string --field duration:double

# Show publish and validation stats (last 3 days)
confidence events usage page-viewed --days 3

# Delete an event definition (prompts for confirmation)
confidence events delete old-event

# JSON output (all commands)
confidence events list --json
confidence events get page-viewed --json

# Dry-run mode (create only)
confidence events create --name test-event --field page:string --dry-run

JSON output

--json wraps the MCP server's text response in a { "data": "..." } envelope. The output is human-readable text, not structured JSON, because the MCP server returns text formatted for AI agents. Structured JSON output might become available if a REST API is added.

filipmyllari

Review notes (AI-assisted). Inline comments below.

filipmyllari · 2026-10-05T08:06:12Z

+  const result = await mcpCallTool(serverOpts(token), 'listEventDefinitions', {
+    pageToken: opts?.pageToken,
+  });
+  return extractText(result);


mcpCallTool returns isError: true results without throwing, and extractText just returns the error text. A server-side failure (e.g. get missing-event) is printed as success and exits 0. Check result.isError and throw (applies to all six wrappers).

filipmyllari · 2026-10-05T08:06:12Z

+    if (format === 'json') {
+      message(formatJson(text));


formatJson(text) is given a string, so --json likely prints an escaped string literal instead of a JSON object (breaks \| jq). Parse first, e.g. parseToolJson. Same in get/create/update/usage.

filipmyllari · 2026-10-05T08:06:12Z

+  const confirmed = await confirm({
+    message: `Delete event definition "${name}"? This cannot be undone.`,
+    default: false,
+  });


confirm() runs unconditionally: it throws or hangs without a TTY (CI/pipes), and --dry-run is ignored. Add --yes, fail when non-interactive without it, and respect --dry-run.

filipmyllari · 2026-10-05T08:06:12Z

+  const schemaKey = `${type}Schema`;
+  return [name, { [schemaKey]: {} }];


Field type isn't validated: amount:dobule sends { dobuleSchema: {} }. Check against an allow-list of supported types.

filipmyllari · 2026-10-05T08:06:12Z

+      const fieldSpecs = (argv.field as string[] | undefined) ?? [];
+      schema = Object.fromEntries(fieldSpecs.map(parseFieldArg));


No --field and no --from-file creates an event with an empty schema. update rejects this case, so create should too.

filipmyllari · 2026-10-05T08:06:12Z

      "@features/*": ["./src/features/*"],
      "@output/*": ["./src/output/*"],
-      "@api/*": ["./src/api/*"]
+      "@network/*": ["./src/network/*"]


@api/* was renamed to @network/*. CLAUDE.md and the cli skill still list @api/*.

filipmyllari · 2026-10-05T08:06:12Z

+): (argv: Record<string, unknown>) => Promise<void> {
+  return async (argv) => {
+    try {
+      await fn(argv as Record<string, unknown>);


Redundant cast. Also, every handler already catches its own errors, so safely only covers requireAuth throwing.

Yes, but safely also formats the error message as fail call. I'd say the unification is worth it, especially since an additional try-catch doesn't really affect the performance that much

Fair point. As a catch-all it guarantees consistent fail output and exit code for anything that slips past the handler's own try/catch, so it's worth keeping. The only remaining nit is the redundant argv as Record<string, unknown> cast; feel free to ignore.

filipmyllari · 2026-10-05T08:06:12Z

+import { formatJson } from '@output/json.js';
+import { resolveFormat } from '@output/detect.js';
+import { requireAuth } from './require-auth.js';
+import { parseFieldArg } from './create.js';


Importing parseFieldArg from create.ts. Move it to its own field-spec.ts.

filipmyllari · 2026-10-05T08:06:12Z

+    const format = resolveFormat(extractFlags(argv));
+    if (format === 'json') {
+      message(formatJson(text));
+    } else {
+      message(text);
+    }


This format/print block is copy-pasted five times. Extract a helper like printToolText(argv, text).

filipmyllari · 2026-10-05T08:06:12Z

+      )
+      .demandCommand(
+        1,
+        'Available actions: setup, list, get, create, update, delete, usage. Run "confidence events --help" for details.',


The action list is hand-maintained and will drift as actions are added.

extractText ignored CallToolResult.isError, silently returning error text as a successful response. Commands like `events get missing-event` would print the error message to stdout and exit 0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Network wrappers now return raw CallToolResult, and a shared printMcpResult helper handles format-aware output. For --json, the MCP text is parsed so the envelope contains a real object instead of an escaped string literal. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add --force/-f to skip confirmation, fail with a clear message when stdin is not a TTY and --force is absent, and respect --dry-run by printing the request body without calling the server. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Reject unknown types like "dobule" with a clear error listing the supported types (string, int, double, bool, struct). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Without --field or --from-file the command silently sent an empty schema. Now it fails early, matching the update command's behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Reject --days outside 1-7 in events usage. Extract isDefined type guard into shared-kernel to replace loose/truthiness undefined checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The MCP client sent a hard-coded '1.0.0' version. Add clientVersion to McpClientOptions and pass the CLI package version so server-side telemetry reflects the actual release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Moves the field parsing logic out of create.ts into its own module so both create and update import from a shared location instead of update reaching into create. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Yargs already prints available commands on missing action, so the hard-coded lists in events and mcp were redundant and prone to drift. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

bespoyasov · 2026-10-05T08:49:31Z

Thanks for the review, @filipmyllari! Updated the code according to most of the comments, left responses to some 🙌

bespoyasov added 8 commits October 5, 2026 08:55

feat(core): add generic REST API client

7a946bb

chore: split handlers into several file, add events MSW stubs

9582bed

feat(cli): add events commands

d2cfe9c

feat(core): add generic MCP client adapter

d99f336

chore: migrate events from REST to MCP

0816c86

chore: clean up testing

2d0fcdf

chore: improve readability

120e525

feat(cli): align commands with current MCP capabilities

f19a108

bespoyasov requested a review from filipmyllari October 5, 2026 07:43

bespoyasov added 2 commits October 5, 2026 09:45

test: fix CI test failing

ad197ff

chore: avoid overmocking

d373956

filipmyllari reviewed Oct 5, 2026

View reviewed changes

bespoyasov and others added 10 commits October 5, 2026 10:18

fix(cli): validate field types in parseFieldArg

f6e94cf

Reject unknown types like "dobule" with a clear error listing the supported types (string, int, double, bool, struct). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(cli): reject events create with no fields or file

d1057cf

Without --field or --from-file the command silently sent an empty schema. Now it fails early, matching the update command's behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(cli): validate --days range and add isDefined guard

082ca31

Reject --days outside 1-7 in events usage. Extract isDefined type guard into shared-kernel to replace loose/truthiness undefined checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

docs: update @api/* path alias references to @network/*

aa94d12

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore(cli): drop hand-maintained action lists from demandCommand

52bf2da

Yargs already prints available commands on missing action, so the hard-coded lists in events and mcp were redundant and prone to drift. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

bespoyasov requested a review from filipmyllari October 5, 2026 08:40

chore: clean up

8a54786

filipmyllari approved these changes Oct 5, 2026

View reviewed changes

bespoyasov merged commit 00cd135 into main Oct 5, 2026
6 checks passed

bespoyasov deleted the feat/events-commands branch October 5, 2026 09:17

github-actions Bot mentioned this pull request Oct 5, 2026

chore: release main #80

Open

		const schemaKey = `${type}Schema`;
		return [name, { [schemaKey]: {} }];

		const fieldSpecs = (argv.field as string[] \| undefined) ?? [];
		schema = Object.fromEntries(fieldSpecs.map(parseFieldArg));

Conversation

bespoyasov commented Oct 5, 2026

Commands

JSON output

Uh oh!

filipmyllari left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bespoyasov Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bespoyasov commented Oct 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

filipmyllari left a comment •

edited

Loading

bespoyasov Oct 5, 2026 •

edited

Loading