Repository navigation
redirects: turn 11 unreachable rules into 4 that work - #2036
Draft
marcleblanc2 wants to merge 1 commit into
Draft
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
- /docs/admin/deploy_executors: the proxy strips /docs before matching, so this never matched. Now /admin/deploy_executors -> /self-hosted/executors, the page its old chain ended on. - /admin/install/cluster.md (two rules, different destinations): .md paths are rewritten to /api/md before the lookup, so neither matched. Now /admin/install/cluster -> /self-hosted/deploy. - 8 #fragment rules for /cody/core-concepts/embeddings/manage-embeddings and .../usage-and-limits: browsers never send the fragment and the bare paths had no rule, so they 404. Now both bare paths -> /cody, matching the neighbouring "Rmv embeddings permanently" rule; the old destinations under /cody/embeddings/ no longer exist either. All four new paths 404 on production today.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third dead-rule cleanup after #1966. Small behaviour change: four paths that 404 on production today start redirecting.
/docs/admin/deploy_executors→https://sourcegraph.com/docs/admin/executors/deploy_executors/docsbefore matching/admin/deploy_executors→/self-hosted/executors(where the old chain ended)/admin/install/cluster.md→/admin/deploy/index.mdand →/admin/deploy(2 rules).mdpaths are rewritten to/api/mdbefore the lookup/admin/install/cluster→/self-hosted/deploy/cody/core-concepts/embeddings/manage-embeddings#…(6 rules) →/cody/embeddings/manage-embeddings#…/cody/core-concepts/embeddings/manage-embeddings→/cody/cody/core-concepts/embeddings/usage-and-limits#…(2 rules) →/cody/embeddings/usage-and-limits#…/cody/core-concepts/embeddings/usage-and-limits→/codyThe embeddings destinations follow the neighbouring
//Rmv embeddings permanentlyrule (/cody/core-concepts/embeddings→/cody/); the old/cody/embeddings/*targets no longer exist either. Happy to point them somewhere better if embeddings docs live on.Verified: first-match table differs on exactly the 6 expected entries (2 unreachable sources gone, 4 bare paths added); file parses to 956 rules.
Independent of the batch 2 and batch 4 PRs; may need a trivial rebase if they merge first.