Repository navigation
fix(media): restrict ffmpeg inputs to media demuxers - #9577
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[High impact] The PR appears safe to merge; no blocking issue remains. SummaryThe PR adds media-format allowlists to FFmpeg and FFprobe inputs. The latest change adds support for animated PNG files through
Reviews (3) · Last reviewed commit: "fix(media): allow apng demuxer" · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
video/mp4was demuxed as DASH and pulled media from a path outside the operation's temp dir into the output (reproduced against the shipped ffmpeg 7.1 viaconvert,probe, and the STT video path)-format_whitelistlimited to media containers (mov/mp4, matroska/webm, avi, flv, asf, mpegts, mpeg, mp3, wav, ogg, flac, aac, aiff, amr, caf, png/jpeg/webp/gif), soconcat,hls,dash, andimfcan no longer be selected by content-f(our own concat list, thelavfisilence source) is added to that input's whitelist rather than exempting it, so nothing opened through it escapes the media listconcatsafe,hls/dashextension allowlists,movenable_drefs). Pinning-safe 1etc. per input was rejected: ffmpeg fails any input whose demuxer doesn't own that optionType of Change
Testing
runFfmpegOperation/extractAudioFromVideobefore and after:.m3u8via declared MIME), and IMF also rejected at the format gatelib/media+lib/audiovitest (67 passing); pinned-argv expectations updated for the new flagChecklist
test-auditauthoring gate)