镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

improvement(ci): check lint and types before pushing - #9555

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/checks-before-push
Nov 2, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/checks-before-push

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Run lint and workspace type checks through Husky before a local push, catching errors before commits are sent to CI.
  • Reuse the existing Turbo task cache and stop the push on either gate's failure.

Type of Change

  • Improvement

Testing

  • Executed the hook through git -c core.hooksPath=.husky push --dry-run; lint and all 29 workspace type checks passed without creating a remote branch.
  • A temporary type error passed a hook-free dry-run control, then the actual hook blocked the same dry-run push with TS2322. The temporary source was removed; no invalid code was committed.
  • After removing the temporary error, the hooked dry-run passed again and the control branch remained absent remotely.
  • Full ship gates: generated artifacts, lint, type-check, 62 audits, repository tests, and block-registry invariants.
  • Hosted CI on the final revision passed, including real database, HTTP, browser and Electron suites. Both reviewers passed with zero open threads.
  • Shell syntax and git diff --check pass. No test assertions changed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing tests passing; no test assertions changed
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 2, 2026 2:32am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Adds a local Husky hook that checks lint and workspace types before pushing.

  • Local pushes run lint and workspace type checks before Git sends commits.

Reviews (1) · Last reviewed commit: "improvement(ci): check lint and types be..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 2da47b9 into staging Nov 2, 2026
71 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/checks-before-push branch November 2, 2026 03:30

This branch was successfully deployed

1 active deployment
Preview — 048b29de Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant