Repository navigation
fix(seo): answer Markdown OPTIONS on unknown paths and list every accepted knowledge-base file type - #9101
Merged
Conversation
…epted knowledge-base file type
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] The PR appears safe to merge. SummaryAdds Markdown 404 responses for
Reviews (1) · Last reviewed commit: "fix(seo): answer Markdown OPTIONS on unk..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPTIONS, so anOPTIONSrequest withAccept: text/markdownto an unknown path gets the Markdown 404 instead of Next's generated 204. Real pages are untouched: the fallback rewrite only runs when no page or route matchedSUPPORTED_DOCUMENT_EXTENSIONS: 15 file types (adds xls, htm, and yml, which the old list of 12 left out); the Dust FAQ uses the same wordingType of Change
Testing
apps/sim/scripts/test-mcp-host-e2e.tsagainst a local dev server: 21/21, with the POST check extended to OPTIONS; removing theOPTIONSexport turns it red (204)apps/sim/scripts/test-landing-seo-e2e.ts: 13/13;/comparisons/dustrenders "15 file types"OPTIONS /pricingreturns the same 400 with and withoutAccept: text/markdownbun run lint,check:source-conventions,check:comment-hygiene,check:unused-exports,check:test-patternsChecklist
test-auditauthoring gate)