Repository navigation
Require Go 1.21+ - #358
Merged
Merged
Require Go 1.21+#358
Conversation
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
sadlerap
approved these changes
Oct 25, 2023
mamachanko
approved these changes
Oct 25, 2023
Contributor
|
I went through my GH notification and read "runtime". My brain went to "reconciler-runtime" and thought "must approve!". 😆 I approve all the runtimes. |
Member
Author
|
@mamachanko no harm, as long as you reviewed before hitting approve |
Contributor
I did! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the nested components already internally require go 1.21 and fail when run (e.g.
make deploy). We don't actively that that command in CI, so the incompatible component bump slipped through.