Repository navigation
Types don't implement controller-runtime's new defaulter and validator interfaces #475
Description
controller-runtime has recently removed its deprecated webhook.Defaulter and webhook.Validator interfaces in favour of webhook.CustomValidator and webhook.CustomDefaulter.
When using the APIs of github.com/servicebinding/runtime in a project that is using a recent controller-runtime, then it does not compile.
../../../go/pkg/mod/github.com/servicebinding/runtime@v1.0.0/apis/v1/clusterworkloadresourcemapping_webhook.go:36:15: undefined: webhook.Defaulter
../../../go/pkg/mod/github.com/servicebinding/runtime@v1.0.0/apis/v1/clusterworkloadresourcemapping_webhook.go:78:15: undefined: webhook.Validator
../../../go/pkg/mod/github.com/servicebinding/runtime@v1.0.0/apis/v1/servicebinding_webhook.go:37:15: undefined: webhook.Defaulter
../../../go/pkg/mod/github.com/servicebinding/runtime@v1.0.0/apis/v1/servicebinding_webhook.go:48:15: undefined: webhook.Validator
Activity
scothis commentedon Apr 1, 2025
It should be possible to delete references to the interfaces that no longer exist, while preserving the methods. The runtime behavior should still work as is. Switching the method to the new interface is also possible, but more work.
Are you interested in implementing this @mamachanko?
mamachanko commentedon Apr 8, 2025
I hope to get around to it asap, but I'm occupied rn.
scothis commentedon Sep 18, 2025
Resolved in #488