镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

document typescript module resolution - #583

Merged
ephys merged 7 commits into
mainfrom
ephys/document-typescript-setup
Apr 11, 2024
Merged

ephys merged 7 commits into
mainfrom
ephys/document-typescript-setup

Conversation

@ephys

@ephys ephys commented Sep 15, 2023

Copy link
Copy Markdown
Member

This PR adds a note in our getting started guide indicating how to configure TypeScript correctly:

image

@github-actions

Copy link
Copy Markdown

@ephys

ephys commented Sep 15, 2023 •

Copy link
Copy Markdown
Member Author

Is this enough for #552 or should I add something somewhere else?

@WikiRik WikiRik mentioned this pull request Sep 15, 2023
3 of 6 tasks
@WikiRik

WikiRik commented Sep 15, 2023

Copy link
Copy Markdown
Member

Possibly in pages like https://6504545ac3c0d91d6d9cb066--sequelize-site.netlify.app/docs/v7/models/defining-models/ where we have an info box about the usage of decorators? By referring in that box to the section in getting started?

@EinfachHans

Copy link
Copy Markdown

Setting resolvePackageJsonExports to true doesn't work for me. I had to set the moduleResolution (and module with it)

@ephys
ephys requested a review from a team as a code owner April 11, 2024 20:16
@ephys
ephys requested a review from WikiRik April 11, 2024 20:16
@github-actions

Copy link
Copy Markdown

@ephys

ephys commented Apr 11, 2024 •

Copy link
Copy Markdown
Member Author

@WikiRik does this change cover it?

Setting resolvePackageJsonExports to true doesn't work for me. I had to set the moduleResolution (and module with it)

Thanks for letting us know

I don't know if there is some interaction between a few different options that make this option incompatible but I think listing both options so people can see which one works for them is the way to go

Comment thread docs/getting-started.mdx Resolved
@github-actions

Copy link
Copy Markdown

@ephys
ephys requested a review from WikiRik April 11, 2024 20:47
@ephys
ephys enabled auto-merge (squash) April 11, 2024 20:50
@github-actions

Copy link
Copy Markdown

@ephys
ephys merged commit 341ea81 into main Apr 11, 2024
@ephys
ephys deleted the ephys/document-typescript-setup branch April 11, 2024 20:56
@QuentinFarizon

Copy link
Copy Markdown

I don't think there really are 2 options, setting resolvePackageJsonExports yields :

error TS5098: Option 'resolvePackageJsonExports' can only be used when 'moduleResolution' is set to 'node16', 'nodenext', or 'bundler'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants