Repository navigation
fmt: improve perf by 78.8% - #1416
Merged
Merged
Conversation
with builtins.sql e2e before: 137.0ms e2e after: 97.5ms
for builtins.sql - improves format perf by 2.6% - drops peak memory drops from 44.2MB to 54.8MB
sbdchd
commented
Oct 16, 2026
| // .children_with_tokens() | ||
| // .filter_map(|it| it.into_token()) | ||
| // .find(|it| it.kind() == kind) | ||
| fn first_child_or_token( |
Owner
Author
There was a problem hiding this comment.
we need to replace rowan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improve parser perf by 6.1% and parse + validation by 19.2%.
e2e builtins.sql
before: 289 ms
after: 61.4 ms