You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use make-fetch-happen instead of node-fetch when downloading compiler #117
The package cannot be used on Windows computers behind a corporate proxy as it is common in many companies. npm itself can download all packages, but download-compiler-for-end-user.js does not respect the proxy configuration.
changed the title [-]Fails to download sass_embedded-*.zip behind proxy[/-][+]Use make-fetch-happen instead of node-fetch when downloading compiler[/+]on Mar 23, 2022
It looks like the issue here is that we use node-fetch to download the compiler instead of make-fetch-happen (which should respect proxy settings automatically).
chrisuehlinger-techslice commented on Apr 12, 2022
Hey there! I'm running into this issue on a project at my job that really needs to get off the old sass+fibers approach.
If I were to submit a PR with this enhancement, would you be willing to review and (if it works) accept it? Or are contributions limited to Sass team members only?
Activity
[-]Fails to download sass_embedded-*.zip behind proxy[/-][+]Use make-fetch-happen instead of node-fetch when downloading compiler[/+]jathak commentedon Mar 23, 2022
It looks like the issue here is that we use
node-fetchto download the compiler instead ofmake-fetch-happen(which should respect proxy settings automatically).chrisuehlinger-techslice commentedon Apr 12, 2022
Hey there! I'm running into this issue on a project at my job that really needs to get off the old sass+fibers approach.
If I were to submit a PR with this enhancement, would you be willing to review and (if it works) accept it? Or are contributions limited to Sass team members only?
nex3 commentedon Apr 18, 2022
We're always happy to review external contributions!
Add a changelog entry for sass/embedded-host-node#117
Add a changelog entry for sass/embedded-host-node#117 (#1719)