Conversation
aagbotemi
force-pushed
the
feat/verification-enum
branch
from
September 29, 2026 17:14
9d90e6b to
9447c48
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BIP-322 defines three validator outputs: valid at time T and age S, inconclusive, and invalid. Two of those lived in
Verificationwhile the third was reported asErr, so the spec's own state machine was split across a Rust idiom.Verificationnow carries all three.Changes
Invalid(Error)variant toVerification.BoxaroundTransactionExtract's source.#[allow(clippy::result_large_err)]from every function.Notes for reviewers
Invalidcarries the fullError, which meansVerificationcan no longer deriveClone,Copy,PartialEqorEq. Error implements none of them, and bitcoin::io::Error can't.Closes #83
Closes #58