镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Diff -> HTML should respect line numbers from input #78

Open

Description

@nathany

Kornelius Kalnbach wrote:

I think we need some special tokens for that:

  • @encoder.line_number 308 || nil sets a new index, which is automatically increased for each line until another one is set.
  • nil turns off line numbers.
  • Maybe we need to send a @@encoder.there_will_be_line_numbers@, which would be equivalent to @encoder.line_number = nil.

TBD:

  • Do we ignore :line_number_start in such a case?

This is more complicated as we really need two columns (old/new line numbers) for this. Seems more like the Diff scanner will be some special thing in the future anyway.

From Redmine: http://odd-eyed-code.org/issues/310

Activity

  1. ghost assigned on Oct 28, 2012
  2. nathany commented on Oct 28, 2012

    @nathany
    ContributorAuthor

    Is this requirement superseded by Water?

  3. nathany commented on Oct 28, 2012

    @nathany
    ContributorAuthor

    Related to #69.

  4. korny commented on Nov 11, 2012

    @korny
    Member

    Is this requirement superseded by Water?

    No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions