Repository navigation
Conversation
gbiggs
approved these changes
Jan 27, 2022
tfoote
approved these changes
Jan 27, 2022
tfoote
left a comment
Member
There was a problem hiding this comment.
This looks like the correct behavior as documented here: https://docs.microsoft.com/en-us/cpp/c-runtime-library/math-constants?view=msvc-170
Contributor
|
Unless this is a backport, I think this should be targeting the |
Merged
Contributor
Author
Contributor
|
No, we will create backport PRs once the Rolling PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, in order to use M_PI,
_USE_MATH_DEFINESmust be defined. SinceM_PIis used in a header file, I think it should be defined at the top instead of requiring any downstream packages using this library to define it themselves.