transformMixedEsModules shouldn't replace typeof exports

Rollup Plugin Name: @rollup/plugin-commonjs
Rollup Plugin Version: 21.0.0

Expected Behavior / Situation

If an ESM file is transformed with transformMixedEsModules=true (for require support), it shouldn't replace typeof exports by 'object' and leave it as-is (or replace by 'undefined' ?)

Actual Behavior / Situation

Right now the bundle fails with exports is not defined because of code in ESM such as lodash-es:
https://github.com/lodash/lodash/blob/es/isBuffer.js#L5

var freeExports = typeof exports == 'object' && exports && !exports.nodeType && exports;
// becomes:
var freeExports = exports && !exports.nodeType && exports;

(lodash-es itself doesn't require transformMixedEsModules, but other parts of the bundle do)

Modification Proposal

If esModule=true do not transform typeof module/exports/module.exports into 'object', as they'll likely open invalid code paths in an ESM.

(I can PR with tests if agreed)

Any progress? lodash-es cause the same error, when I use Vite with transformMixedEsModules=true.

fix(commonjs): do not transform "typeof exports" for mixed modules

I added a fix to #1038

fix(commonjs): do not transform "typeof exports" for mixed modules

I added a fix to #1038

Hello, when will it be released?

@theprimone we don't have a release schedule. please exercise patience.

@theprimone we don't have a release schedule. please exercise patience.

Well，how can I make a workaround？It causes error after bundled, though I try to configure exclude.

It looks like version @rollup/plugin-commonjs@22.0.0-4 fixes the problem for now, detail: https://unpkg.com/browse/@rollup/plugin-commonjs@22.0.0-4/dist/index.es.js

fix(commonjs): do not transform "typeof exports" for mixed modules

@yunsii

@yunsii I didn't solve it.update@rollup/plugin-commonjs@22.0.0-9,use commonjsOptions: { transformMixedEsModules: true, strictRequires: true, }

@yunsii

@yunsii I didn't solve it.update@rollup/plugin-commonjs@22.0.0-9,use commonjsOptions: { transformMixedEsModules: true, strictRequires: true, }

The same error: exports is not defined? I replace require with import ... from ... and remove commonjs plugin finnally 😂

fix(commonjs): do not transform "typeof exports" for mixed modules

Workaround while waiting for the fix to release:

Add window.exports = undefined before anything else executes.
For me, I had to do it in a separate script tag above the main file:

<script>
  // Workaround for https://github.com/rollup/plugins/issues/1014
  window.exports = undefined
</script>

fix(commonjs): do not transform "typeof exports" for mixed modules

help me vite 2.6.8 still has this problem Uncaught ReferenceError: exports is not defined

fix(commonjs): do not transform "typeof exports" for mixed modules

fix(commonjs): support CJS modules re-exporting transpiled ESM modules (

fix(commonjs): do not transform "typeof exports" for mixed modules

fix(commonjs): support CJS modules re-exporting transpiled ESM modules (

fix(commonjs): do not transform "typeof exports" for mixed modules (#…

Navigation Menu

Repository navigation

transformMixedEsModules shouldn't replace typeof exports #1014

Expected Behavior / Situation

Actual Behavior / Situation

Modification Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

transformMixedEsModules shouldn't replace typeof exports #1014

Description

Expected Behavior / Situation

Actual Behavior / Situation

Modification Proposal

Activity

yunsii commented on Dec 8, 2021

lukastaegert commented on Dec 10, 2021

yunsii commented on Dec 17, 2021

shellscape commented on Dec 17, 2021

yunsii commented on Dec 17, 2021

yunsii commented on Dec 19, 2021

webhao commented on Feb 10, 2022

yunsii commented on Feb 10, 2022

mccxiv commented on Feb 24, 2022

superchangme commented on Mar 30, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions