Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mathmodule used floats, which suffer from precision errors, so that's obviously bad.In the Ethereum universe, though, everything is generally some fixed decimal size, with fixed18 being the predominant unit (1 eth).
This PR was heavily assisted by AI. It attempts to remove all the float logic and replace it with a new module called
units. That module is a facade around shopspring/decimal.The conflicts are vaguely to be expected- this is a large PR that touches a lot of code.
My agent wants me to call your attention to the changes in bindings/rocketpool/contract.go and bindings/utils/multicall/multicaller.go, where we convert units.Wei to big.Int and vice versa, as needed.