镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Unify various exec calls #81

Closed
Closed

Description

@chenglou

I'll cc @cristianoc, @mewhhaha and @john-pangalos (sorry for the ping) on this one.

Currently in the codebase there are 3 ways to call a binary:

We should really revisit those and streamline them:

  • First one:
    • should be execFile, which avoids needing to escape the command path.
    • should also be sync.
    • should work on windows, if it isn't.
  • Second one:
    • should use execFile in the win32 branch too, to avoid needing to escape path. Can't use that for a batch script
  • Third one

Activity

  1. mewhhaha commented on Feb 7, 2021

    @mewhhaha
    Contributor

    For the second case we followed the documentation on NodeJS. Is it possible to get around that if the file is a script?

    What's the condition for getting the popup for starting this process? Is it by having a single .res file open in the project?

  2. chenglou commented on Feb 10, 2021

    @chenglou
    MemberAuthor

    Oh right, yeah thanks for the reminder. I've finally understood the little complexities here. (Thanks also to @bsansouci for debugging on windows with me). d1dc096 fixes everything.

    Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions