add syntax for string interpolation #275

Activity

1. cristianoc commented on Jun 22, 2021

   

   cristianoc

   on Jun 22, 2021

   Collaborator

   More actions

   Is this about syntax highlighting?
2. cristianoc

   added

   enhancementNew feature or requestNew feature or request

   on Jun 22, 2021
3. amiralies commented on Jun 22, 2021

   

   amiralies

   on Jun 22, 2021 via email

   ContributorAuthor

   More actions

   Yes

   …

   On Tue, Jun 22, 2021, 7:54 AM Cristiano Calcagno ***@***.***> wrote: Is this about syntax highlighting? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#275 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFFSICOSPHWVTO5FNUIO23TT7655ANCNFSM46XRCQFA> .
4. zth commented on Feb 26, 2022

   

   zth

   on Feb 26, 2022

   Member

   More actions

   @amiralies is this still relevant, or was this fixed by the recent changes to highlighting?
5. amiralies commented on Feb 26, 2022

   

   amiralies

   on Feb 26, 2022

   ContributorAuthor

   More actions

   I'm not sure, as I vscode is not my main editor.

   I think these cases should be covered.

   let var = `hello ${name} how you doin?`
   
   let var2 = j`hello ${name} how you doin?`
   
   let var3 = j`hello $name how you doin?`
   
   let varInvalid = `hello $name how you doin?`
   
   let expr = `2 + 2 is ${Int.toString(2 + 2)}`
6. zth commented on Feb 26, 2022

   

   zth

   on Feb 26, 2022

   Member

   More actions

   Right. Well, at least on my theme, it's not fully highlighted:
   
7. amiralies commented on Feb 26, 2022

   

   amiralies

   on Feb 26, 2022

   ContributorAuthor

   More actions

   This is current vim behavior.
   
   looks like var3 and expr case should be addressed, this might be tricky to implement in textmate grammars tho .
8. zth commented on Mar 20, 2022

   

   zth

   on Mar 20, 2022

   Member

   More actions

   This is very close to being fixed in the semantic highlighting PR:

   

   Will see if we can fix the $name case there too, so we can close this.
9. cristianoc

   closed this as completedin #367on Mar 23, 2022