Highlighting of JSX tags #21

Activity

1. tkovs commented on Nov 26, 2020

   

   tkovs

   on Nov 26, 2020

   More actions

   Here it is working for my own components

   
2. jfrolich commented on Nov 26, 2020

   

   jfrolich

   on Nov 26, 2020

   ContributorAuthor

   More actions

   Interesting! That is not working for me. What version of the extension are you using?
3. tkovs commented on Nov 29, 2020

   

   tkovs

   on Nov 29, 2020

   Last edited by tkovs

   More actions

   Interesting! That is not working for me. What version of the extension are you using?

   
4. jfrolich commented on Nov 30, 2020

   

   jfrolich

   on Nov 30, 2020

   ContributorAuthor

   More actions

   I found out that it is just that my theme didn't color the entity.name.namespace. Many themes do not, because I had this hypothesis that my theme wasn't displaying them and swapped a few themes and they also didn't. Dark+ does however. You can also add the value in the settings:

     "editor.tokenColorCustomizations": {
       "textMateRules": [
         {
           "name": "JSX",
           "scope": ["entity.name.namespace"],
           "settings": {
             "foreground": "#80CBC4"
           }
         },
         // you might also want to set this for polymorphic variants
         {
           "name": "other",
           "scope": ["punctuation.definition.keyword"],
           "settings": {
             "foreground": "#f87086"
           }
         }
       ]
     }

   👍React with 👍5Reacted by Julien Elbaz, Max T., Paweł Falisz, Christoph and Shourya Bansal
5. Faliszek commented on Dec 8, 2020

   

   Faliszek

   on Dec 8, 2020

   Last edited by Faliszek

   More actions

   @jfrolich thanks for the solution, i also wanted to highlight in my theme jsx element and their attributes but I found out, that with actual grammar this it is not possible yet(?).
   What i mean is, in .re file with ocaml-platform extension when i check it with Cmd + Shift + P and pick DM: Inspect editor tokens and scopes i get something like this when checking

   

   but right now they are not assigned to any scope

   

   Is it bug... or it is something that won't be implemented?

   PS. I was thinking about it creating new issue, but this is also related to jsx so i thought it might good place to point that out because i think lot's of themes are decorating jsx in this manner

   👍React with 👍2Reacted by Charles Badger and Shourya Bansal
6. Faliszek commented on Dec 10, 2020

   

   Faliszek

   on Dec 10, 2020

   Last edited by Faliszek

   More actions

   Hm, i can see that there is already pull request open with adding this feature

   #8
7. cristianoc

   added

   enhancementNew feature or requestNew feature or request

   on Jun 7, 2021
8. cristianoc

   closed this as completedin #367on Mar 23, 2022