Jump to def doesn't work inside JSX fragment

Here's the code I have, and cmd+click on SectionHeader, the tool jumps to React.re on line 3.

<>
      <SectionHeader>
            {ReasonReact.string(heading)}
      </SectionHeader>
</>

@rickyvetter

This is in a series of issues related to JSX ppx that we should solve from first principles.
Currently:

the ppx generates several symbols at the same location.
the editor tries to heuristically figure out what's going on: which of the symbols at that same location it should deal with.

There are several issues posted these days in this repo, that have the same root.
Planning to investigate this starting from the react ppx level first.
++ @rickyvetter

These probably related:
#181
#180
#177

I just opened #183 which is probably related as well

Labeling all these with jsx meaning: not going to address them separately from changes to the ppx for JSX.

Add more heuristics for JSX inside fragments.

just getting started

Navigation Menu

Repository navigation

Jump to def doesn't work inside JSX fragment #182

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Jump to def doesn't work inside JSX fragment #182

Description

Activity

cristianoc commented on Apr 27, 2021

cristianoc commented on Apr 27, 2021

bsansouci commented on Apr 28, 2021

cristianoc commented on Apr 28, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions