Refactor wish list #1094

Activity

1. fhammerschmidt commented on May 16, 2025

   

   fhammerschmidt

   on May 16, 2025

   Last edited by fhammerschmidt

   Member

   More actions

   At some point the server part should be in OCaml (#269).
   Then we only have a small client left where we could get rid of the typescript dependency entirely. The client might not be too much work to rewrite in ReScript instead?
2. nojaf commented on May 16, 2025

   

   nojaf

   on May 16, 2025

   ContributorAuthor

   More actions

   At some point the server part should be in OCaml (#269).

   True, but all the above are feasible. I started working on an OCaml LSP some time ago: https://github.com/nojaf/rescript/tree/lsp. It is a lot of work, and I became a bit demotivated upon learning that the analysis-tool currently relies on being run as a single execution. During the retreat, there was also mention of possibly doing this in Rust. I'm not sure which option is the lesser evil, though.
3. nojaf commented on May 16, 2025

   

   nojaf

   on May 16, 2025

   ContributorAuthor

   More actions

   The client might not be too much work to rewrite in ReScript instead?

   Yeah, that could be fun to have in the end.
4. mediremi commented on May 16, 2025

   

   mediremi

   on May 16, 2025

   Member

   More actions

   We probably want to switch from TextDocumentSyncKind.Full to TextDocumentSyncKind.Incremental (see "Incremental Text Document Synchronization" from the language server extension guide) and use VS Code's TextDocuments documents manager instead of rolling our own file content cache as we currently do.

   import {
     createConnection,
     TextDocumentSyncKind
   } from 'vscode-languageserver/node';
   import {
     TextDocuments
   } from 'vscode-languageserver';
   import { TextDocument } from 'vscode-languageserver-textdocument';
   
   const connection = createConnection();
   const documents = new TextDocuments(TextDocument);
   documents.listen(connection);
   
   connection.onInitialize(() => ({
     capabilities: {
       textDocumentSync: TextDocumentSyncKind.Incremental
     }
   }));
   
   connection.listen();

   👍React with 👍1Reacted by Florian Verdonck