Repository navigation
Isolate workflow tests from user deployment configuration - #80
Merged
jacobprall merged 1 commit intoOct 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid edits to
factory.config.tscould break the template's own tests: a single verification command threw during test collection, while a non-mainbranch failed hardcoded assertions. Tests across routing, claims, cancellation, and workflows also derived their subjects from mutable operator settings.Vitest now replaces the deployment file at its module boundary with explicit test fixtures. The real application configuration resolver, permissions, publishing, and cleanup code remain in use. Added behavior cases select different repositories and branches with empty, single, and three-command verification lists, checking draft publishing and COMMENT review behavior. Contributor guidance identifies fixture ownership.
Developers can customize their deployment without reshaping valid configuration to satisfy template test assumptions. No production runtime behavior changed and existing authority/security assertions remain effective.
Validation:
npm run checkpassed — 26 files, 176 tests. The complete check also passed with five temporary deployment configurations: single verify, empty verify, three verify commands,master, and multiple repositories with distinct non-main branches. Each variant additionally changed labels, prefix, required permission, limits, and timeout. The original deployment file was restored byte-for-byte; the lockfile is unchanged.Fixes #76.