Repository navigation
Return safe workflow failures with trace correlation - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed or canceled parent workflows currently expose raw task diagnostics through polling, and the CLI prints them. Return a stable public error with a correlation
trace_idderived only after the signed question ID has been verified. Operators can use that ID to inspect the raw diagnostic in the Render Dashboard.Keep HTTP 200 and
status: "failed", display the safe error and trace in the CLI, and preserve active states, successful replies, missing-result behavior, and completed user-safe failure replies. Do not add raw diagnostic logging.Validation: four regressions failed before the fix for failed/canceled API responses and real CLI subprocesses consuming those responses from the local API. Focused tests: 20 passed. Independently rerun typecheck/full suite: 86 passed, 1 live-model test skipped. Frozen install/diff checks passed; dependencies are unchanged. The fixture also supports the separate question-ID signing-secret change.
No live Render or paid-model validation was performed.
Fixes #29.