镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

RC: Self-managed encryption keys Private Preview branch - #1740

Merged
mich-elle-luna merged 29 commits into
mainfrom
preview-cmek
Oct 14, 2026
Merged

mich-elle-luna merged 29 commits into
mainfrom
preview-cmek

Conversation

@cmilesb

@cmilesb cmilesb commented Jun 23, 2025 •

Copy link
Copy Markdown
Contributor

This is a draft PR for the preview of Customer-managed encryption keys. Will be merged to main for public preview.


Note

Low Risk
Documentation-only changes for a preview feature; no application code, auth, or data paths are modified.

Overview
Adds Redis Cloud Pro self-managed (customer-managed) persistent storage encryption documentation for the private preview, including a new security guide and wiring into the Pro database creation flow.

The new manage-encryption-keys.md page covers prerequisites, enabling Customer managed key on a new Pro subscription (pending state until key access is granted, 7-day cleanup), AWS and Google Cloud key policy/IAM steps, shared final steps via rc-cmek-final-steps.md (deletion grace period options, SLA warning for alert-only, Activate), key rotation limits (no ARN swap), and behavior when key access is revoked.

create-pro-database-new.md documents Persistent storage encryption under Setup advanced options and links to the new guide. It also replaces Hugo {{<image>}} shortcodes with standard Markdown images and separate {width=...} attribute lines across the page.

Reviewed by Cursor Bugbot for commit 9ca3f41. Bugbot is set up for automated code reviews on this repo. Configure here.

@cmilesb
cmilesb requested a review from joniredis June 23, 2025 18:02
@cmilesb cmilesb self-assigned this Jun 23, 2025
@jit-ci

jit-ci Bot commented May 22, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@CLAassistant

CLAassistant commented Aug 13, 2026 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mich-elle-luna
✅ cmilesb
❌ Cameron Bates


Cameron Bates seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mich-elle-luna
mich-elle-luna marked this pull request as ready for review September 14, 2026 18:00
@mich-elle-luna
mich-elle-luna requested review from a team and removed request for joniredis September 14, 2026 18:01
@mich-elle-luna mich-elle-luna self-assigned this Sep 14, 2026

@dwdougherty dwdougherty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language LGTM. Several of the GC links came up in French language; not sure why. Probably good to confirm on your end.

- Point Google Cloud documentation links at docs.cloud.google.com.
- Say Redis uses the key for storage encryption and for recovery.
- Add a section on rotating key material or key versions, and note that
  changing to a different key isn't supported.
- List every deletion grace period option, including the timed ones, in
  the final steps and in Revoke key access.
- Add Active-Active guidance for keys per region, with a screenshot of
  the per-region key resource name fields.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mich-elle-luna mich-elle-luna added the rc Redis Cloud docs label Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Redis Memory

Found 8 related items from repository history (1 new this commit):

Memory updated at 9ca3f41

mich-elle-luna and others added 2 commits October 13, 2026 11:56
Also say that all persistent data on Redis Cloud is encrypted at rest,
rather than all data.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
An earlier merge resolution kept both sides of create-pro-database-new.md.
The Advanced options table had a blank line after the header row, which
ended the table there, plus duplicate VPC configuration and Public
endpoint access rows and a stale Cloud account row. The page had also
reverted main's Markdown images to the older image shortcode. Take main's
version and re-add the Persistent storage encryption row after Public
endpoint access, so the page differs from main by that one row.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mich-elle-luna
mich-elle-luna merged commit 46f775c into main Oct 14, 2026
98 of 99 checks passed
@mich-elle-luna
mich-elle-luna deleted the preview-cmek branch October 14, 2026 13:47
EliShteinman pushed a commit to EliShteinman/docs that referenced this pull request Oct 15, 2026
The CMEK pages were written while the {{< image >}} shortcode still
existed. main has since converted every image to Markdown syntax and
removed the shortcode, so merging preview-cmek (redis#1740) broke the build:

  content/embeds/rc-cmek-final-steps.md:14:5: failed to extract
  shortcode: template for shortcode "image" not found

Convert the six remaining uses, five in manage-encryption-keys.md and one
in the rc-cmek-final-steps embed, to ![Alt](/images/...) plus a
{width="..."} attribute line, keeping the alt text and widths. make ci
passes on main with this change.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
EliShteinman added a commit to EliShteinman/docs that referenced this pull request Oct 15, 2026
Add the Redis Cloud self-managed encryption keys (CMEK) private preview page for AWS and Google Cloud.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rc Redis Cloud docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants