镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix Nebius profile bootstrap on fresh pods - #106

Merged
taagarwa-rh merged 1 commit into
redhat-et:mainfrom
rounakbende10:fix/nebius-profile-bootstrap
Oct 15, 2026
Merged

taagarwa-rh merged 1 commit into
redhat-et:mainfrom
rounakbende10:fix/nebius-profile-bootstrap

Conversation

@rounakbende10

Copy link
Copy Markdown
Collaborator

The queue was crashing on fresh startup because it tried to list Nebius profiles before the CLI config existed. This creates the profile first and updates it if it’s already there.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: fb8a4a4d-106b-4748-8510-67d6014b05db
📥 Commits

Reviewing files that changed from the base of the PR and between bff3617 and 4d0d04a.

📒 Files selected for processing: 2
  • src/coding_agent_bench/nebius_utils.py
  • tests/test_nebius_concurrency.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Improved profile setup when a profile already exists: setup now updates its credentials after detecting the existing profile.
    • New profiles are created directly with the required connection and credential settings.

create_profile now attempts profile creation directly. If the command reports that the profile already exists, it updates the profile credentials. Tests cover the existing-profile and fresh-configuration command sequences.

Changes: Nebius profile creation and credential update

Layer / File(s) Summary
Create or update a profile
src/coding_agent_bench/nebius_utils.py, tests/test_nebius_concurrency.py
create_profile attempts profile create without listing profiles first. It updates credentials when the creation error contains “already exists” and re-raises other errors. Tests check the existing-profile and fresh-configuration command sequences.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: taagarwa-rh

Merge Risk: ⚪ Minimal · up to 4d0d0

No confirmed issue blocks merging. The existing-profile fallback still depends on unverified CLI error wording.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly states that the change fixes Nebius profile setup on fresh pods.
Description check Passed The description explains the fresh-start failure and the profile creation and update behavior changed in this pull request.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@taagarwa-rh
taagarwa-rh merged commit 3ff378a into redhat-et:main Oct 15, 2026
1 check passed
@rounakbende10
rounakbende10 deleted the fix/nebius-profile-bootstrap branch October 15, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants