Repository navigation
Check JDK for javac - #4368
Closed
snjeza wants to merge 1 commit into
Closed
Check JDK for javac#4368snjeza wants to merge 1 commit into
snjeza wants to merge 1 commit into
Conversation
Collaborator
|
so it turns out we don't actually need to enforce a jdk 26 requirement for the javac plugin, it's only required if the user needs to compile against java 26. Which will most likely not be the case for a majority of users. I think we should keep this PR on the backburner for now. |
jglick
reviewed
Aug 3, 2026
| const preferenceName = javaPreferences.preference; | ||
| let javaHome = javaPreferences.javaHome; | ||
| let javaVersion: number = 0; | ||
| const REQUIRED_JDK_VERSION = ('on' === getJavaConfiguration().get('jdt.ls.javac.enabled'))?25:21; |
There was a problem hiding this comment.
By the way https://github.com/redhat-developer/vscode-java/wiki/Javac%E2%80%90based-compilation-support currently says 24 is required; should that say 25?
Contributor
|
This PR changes the import, but it doesn't seem to change which file is looked for elsewhere. @datho7561 Maybe close this? |
Contributor
|
Given we're dropping the javac plugin, let's close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @fbricon