Repository navigation
chore(ci): stop pinning plugin versions in the E2E deployments - #5711
Open
gustavolira wants to merge 2 commits into
Open
gustavolira wants to merge 2 commits into
gustavolira wants to merge 2 commits into
Conversation
…heck diff-values_showcase-sanity-plugins.yaml pinned 27 community plugins to ghcr.io/redhat-developer/rhdh-plugin-export-overlays builds tagged bs_1.49.4 (added in redhat-developer#4731 when they left the catalog index). None of them is in the 2.1 or next catalog index, and they are not what users get: the Extensions Catalog serves bs_1.54.9 builds for 26 of them. The overlays Plugin Sweep already installs and boots all 27 daily at their current tags. Keeping them here tested April builds for Backstage 1.49.4 on a 1.54.9 hub, and the pins themselves broke the job (RHDHBUGS-3116, RHDHBUGS-3123). The ref:// entries, the guest provider and the four specs stay unchanged. Outcome of the spike RHIDP-18207. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5711 +/- ##
==========================================
- Coverage 75.70% 69.00% -6.70%
==========================================
Files 65 58 -7
Lines 708 555 -153
Branches 100 83 -17
==========================================
- Hits 536 383 -153
Misses 171 171
Partials 1 1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Author
|
/test ? |
Member
Author
|
/test e2e-ocp-helm-nightly |
The rest of the hand-pinned ghcr.io/redhat-developer/rhdh-plugin-export-overlays builds in the E2E deployments go away, so no plugin version is written in this repository any more: - The oidc and guest auth providers (bs_1.52.0 / bs_1.54.6 pins from redhat-developer#5258 and redhat-developer#5538) are now in the catalog index, on next and on 2.1, so they become ref:// entries in values_showcase*.yaml, the sanity plugins values and the runtime deployment config. ref:// resolves to the build the index ships, which follows every release with no edit here. - roadiehq-backstage-plugin-github-pull-requests:bs_1.49.4 is dropped from values_showcase*.yaml: it is not in the index and only a blocked spec (playwright/blocked/github-happy-path.blocked.ts) refers to it. The OCP PR check signs in through the oidc provider, so it validates the ref:// switch for showcase and showcase-rbac. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
|
@gustavolira: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The E2E deployments pinned plugin builds from
ghcr.io/redhat-developer/rhdh-plugin-export-overlaysby hand (bs_1.49.4,bs_1.52.0andbs_1.54.6tags). Those pins go stale with every Backstage bump, and nobody updates them. After this PR no plugin version is written in the repository: every plugin the E2E deployments install comes from the catalog index throughref://, which resolves to the build the index ships for that release.Sanity plugins check (
diff-values_showcase-sanity-plugins.yaml). Drops 27 community builds pinned tobs_1.49.4, added in #4731 when the plugins left the catalog index.nextindex.bs_1.54.9builds for 26 of them.Community plugins are owned and tested in rhdh-plugin-export-overlays. A follow-up there will check every community plugin, at the build its metadata points to, in the real RHDH image.
Auth providers. The oidc and guest providers (pinned in #5258 and #5538) are now in the catalog index on
nextand 2.1. They becomeref://invalues_showcase*.yaml, the sanity values andplaywright/utils/runtime-config.ts.github-pull-requests.
roadiehq-backstage-plugin-github-pull-requests:bs_1.49.4is dropped fromvalues_showcase*.yaml. It is not in the index, and only a blocked spec (playwright/blocked/github-happy-path.blocked.ts) refers to it.Which issue(s) does this PR fix
PR acceptance criteria
How to test changes / Special notes to the reviewer
e2e-ocp-helm) covers the auth-provider switch forshowcaseandshowcase-rbac.showcase-sanity-pluginsandshowcase-runtimeprojects only run in the OCP Helm nightly, so please also run/test e2e-ocp-helm-nightly.unit/runtime-config.test.tspasses (21 tests).🤖 Generated with Claude Code