镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

[3.x] Improve PHP 8.5+ support by avoiding deprecated method calls in tests #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 3 commits into from
Oct 3, 2026
Merged

[3.x] Improve PHP 8.5+ support by avoiding deprecated method calls in tests #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b190e8
[3.x] Run CI jobs on PHP8.5
WyriHaximus Nov 18, 2025
21346c1
[3.x] Fix reflection setAccessible deprecatoin warnings
WyriHaximus Nov 18, 2025
9f7df57
[3.x] Skip writing to a closed stream test on PHP8.5
WyriHaximus Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
strategy:
matrix:
php:
- 8.5
- 8.4
- 8.3
- 8.2
Expand Down Expand Up @@ -42,7 +43,7 @@ jobs:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
with:
php-version: 8.2
php-version: 8.5
coverage: xdebug
ini-file: development
- run: composer install
Expand Down
4 changes: 3 additions & 1 deletion tests/DuplexResourceStreamTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ public function testConstructWithoutLoopAssignsLoopAutomatically(): void
$stream = new DuplexResourceStream($resource);

$ref = new \ReflectionProperty($stream, 'loop');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$loop = $ref->getValue($stream);

$this->assertInstanceOf('React\EventLoop\LoopInterface', $loop);
Expand Down
4 changes: 3 additions & 1 deletion tests/ReadableResourceStreamTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ public function testConstructWithoutLoopAssignsLoopAutomatically(): void
$stream = new ReadableResourceStream($resource);

$ref = new \ReflectionProperty($stream, 'loop');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$loop = $ref->getValue($stream);

$this->assertInstanceOf('React\EventLoop\LoopInterface', $loop);
Expand Down
8 changes: 7 additions & 1 deletion tests/WritableResourceStreamTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ public function testConstructWithoutLoopAssignsLoopAutomatically(): void
$stream = new WritableResourceStream($resource);

$ref = new \ReflectionProperty($stream, 'loop');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$loop = $ref->getValue($stream);

$this->assertInstanceOf('React\EventLoop\LoopInterface', $loop);
Expand Down Expand Up @@ -509,6 +511,10 @@ public function testDoubleCloseWillEmitOnlyOnce(): void
*/
public function testWritingToClosedWritableResourceStreamShouldNotWriteToStream(): void
{
if (PHP_VERSION_ID >= 80500) {
$this->markTestSkipped('Since PHP 8.5 attempting to write to a closed stream will result in an error');
}

$stream = fopen('php://temp', 'r+');
assert(is_resource($stream));

Expand Down