Repository navigation
Remove unneeded cyclic dependency on react/socket - #96
Merged
Merged
Conversation
WyriHaximus
approved these changes
Feb 27, 2018
jsor
approved these changes
Feb 27, 2018
stardothosting
pushed a commit
to stardothosting/dns
that referenced
this pull request
Oct 28, 2026
Remove unneeded cyclic dependency on react/socket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trivial PR removes the currently unneeded dependency on react/socket, which in turn depends on react/dns again. By removing this cyclic dependency, we can ensure Composer will automatically and correctly pick the latest installed version without having to specify the root package version.
This change was previously suggested by @cboden in #79. After considering this again, I came to the conclusion that I would rather get this in now and eventually look into how we can avoid this once we implement #19. This change includes documentation updates and effectively reverts parts of #71.
The updated dependency graph now looks like this:
Builds on top of #79, thank you @cboden!