Repository navigation
Make the default configuration constexpr - #2050
Merged
Merged
Conversation
Summary: Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D127577561
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127577561. |
meta-codesync Bot
pushed a commit
to meta/litho
that referenced
this pull request
Oct 26, 2026
Summary: X-link: react/react-native#59515 X-link: react/yoga#2050 Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D127577561 fbshipit-source-id: 017d21f8b797e412649fde0b5829df17f464436c
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: #59515 X-link: react/yoga#2050 Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D127577561 fbshipit-source-id: 017d21f8b797e412649fde0b5829df17f464436c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton.
Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D127577561