Determining the availability of props.visible #95

Activity

1. benjycui commented on Aug 24, 2017

   

   benjycui

   on Aug 24, 2017

   Member

   More actions

   But why, are you going to lint code in node_modules.
2. devdammit commented on Aug 24, 2017

   

   devdammit

   on Aug 24, 2017

   Author

   More actions

   @benjycui, No, of course, we do not check node_modules into the style code. :)
   We have our UIkit, and we made a wrapper for rcTooltip. In this wrapper we describe props
3. benjycui commented on Aug 25, 2017

   

   benjycui

   on Aug 25, 2017

   Member

   More actions

   Why not check for undefined?

   Yep, you can PR.

   But I don't agree with this ESLint rule, we can set default prop for defaultXXX, but I don't think we should set default props for controlled props(e.g. value, visible..)
4. oldwin commented on Nov 29, 2017

   

   oldwin

   on Nov 29, 2017

   More actions

   @benjycui I agree with @mochachai, need to check it for undefined. For example in my case I need to use rc-tooltip in two different scenes inside the one component.

   1. Will work like a standard tooltip
   2. Will show preview with always opened tooltip

   So I was going to just pass true or undefined in 'visible' props, but now I have to do one trick:

   const props = {};
   if (preview) {
     props.visible = true;
   }
   
   return (
     <Tooltip placement="bottom" {...props} />
   )